Re: [PATCH] DROP tab completion - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] DROP tab completion
Date
Msg-id YabY21Aa52x/iUMI@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] DROP tab completion  (Asif Rehman <asifr.rehman@gmail.com>)
List pgsql-hackers
On Tue, Nov 30, 2021 at 03:17:07PM +0000, Asif Rehman wrote:
> The patch applies cleanly and the functionality seems to work well. (master e7122548a3)
>
> The new status of this patch is: Ready for Committer

+   else if (Matches("DROP", "MATERIALIZED", "VIEW", MatchAny))
+       COMPLETE_WITH("CASCADE", "RESTRICT");
[...]
+   else if (Matches("DROP", "OWNED", "BY", MatchAny))
+       COMPLETE_WITH("CASCADE", "RESTRICT");
This stuff is gathered around line 3284 in tab-complete.c as of HEAD
at 538724f, but I think that you have done things right as there are
already sections for those commands and they have multiple keywords.
So, applied.  Thanks!
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Greg Nancarrow
Date:
Subject: Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Next
From: Amit Kapila
Date:
Subject: Re: row filtering for logical replication