Re: pg_waldump stucks with options --follow or -f and --stats or -z - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_waldump stucks with options --follow or -f and --stats or -z
Date
Msg-id YZYNG/owU8X0UqQN@paquier.xyz
Whole thread Raw
In response to Re: pg_waldump stucks with options --follow or -f and --stats or -z  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: pg_waldump stucks with options --follow or -f and --stats or -z
List pgsql-hackers
On Thu, Nov 18, 2021 at 01:32:08PM +0530, Bharath Rupireddy wrote:
> Hm. So, the pg_waldump can have handlers for SIGINT, SIGTERM, SIGQUIT
> and then it should emit the computed stats in those handlers the
> comobinations - "-s/-f/-z" and "-s/-e/-f/-z". I'm okay with this
> behaviour. Michael Paquier had suggested the same upthread. If okay, I
> will work on that patch.

While on it, I am pretty sure that we should add in the stats report
the start and end LSNs matching with the reports.  If you use --follow
and the call is interrupted, we would not really know to which part of
the WAL stream a report applies to without this information, likely in
the shape of an extra header.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: CREATE tab completion
Next
From: Bharath Rupireddy
Date:
Subject: Re: pg_waldump stucks with options --follow or -f and --stats or -z