Re: Some RELKIND macro refactoring - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Some RELKIND macro refactoring
Date
Msg-id YSXYuxLv+ed/Dy0v@paquier.xyz
Whole thread Raw
In response to Re: Some RELKIND macro refactoring  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: Some RELKIND macro refactoring  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On Tue, Aug 24, 2021 at 12:01:33PM +0200, Peter Eisentraut wrote:
> While analyzing this again, I think I found an existing mistake.  The
> handling of RELKIND_PARTITIONED_INDEX in RelationGetNumberOfBlocksInFork()
> seems to be misplaced.  See attached patch.

Right.  This maps with RELKIND_HAS_STORAGE().  Makes me wonder whether
is would be better to add a check on RELKIND_HAS_STORAGE() in this
area, even if that's basically the same as the Assert() already used
in this code path.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "tanghy.fnst@fujitsu.com"
Date:
Subject: RE: Skipping logical replication transactions on subscriber side
Next
From: Michael Paquier
Date:
Subject: Re: Postgres perl module namespace