Re: Two patches to speed up pg_rewind. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Two patches to speed up pg_rewind.
Date
Msg-id YRxXdyWNfzwhHAP+@paquier.xyz
Whole thread Raw
In response to Re: Two patches to speed up pg_rewind.  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Tue, Aug 17, 2021 at 04:47:44PM +0900, Michael Paquier wrote:
> One argument
> against this approach is that if pg_rewind fails in the middle of its
> operation then we would have done a set of fsync() for nothing, with
> the data folder still unusable.

I was skimming through the patch this morning, and that argument does
not hold much water as the flushes happen in the same place.  Seems
like I got confused, sorry about that.

> I would be curious to see some
> numbers to see how much it matters with many physical files (say cases
> with thousands of small relations?).

For this one, one simple idea would be to create a lot of fake
relation files with a pre-determined size and check how things
change.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Support for NSS as a libpq TLS backend
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH]Remove obsolete macro CHECKFLOATVAL in btree_gist