Re: [PATCH] test/ssl: rework the sslfiles Makefile target - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] test/ssl: rework the sslfiles Makefile target
Date
Msg-id YRMeKp9HG4LGBQWi@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] test/ssl: rework the sslfiles Makefile target  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: [PATCH] test/ssl: rework the sslfiles Makefile target  (Jacob Champion <pchampion@vmware.com>)
List pgsql-hackers
On Tue, Aug 10, 2021 at 09:36:14AM +0200, Daniel Gustafsson wrote:
> I personally think the increased readability and usability from what we have
> today warrants the changes.  Is it the use of .SECONDARY or the change in the
> global Makefile you object to (or both)?

The part I am mainly objecting to is the change in Makefile.global.in,
but I have to admit after thinking about it that enforcing SECONDARY
may not be a good idea if other parts of the system rely on that, so
encouraging the use of clean_intermediates may be dangerous (Tom's
point from upthread).

I have not tried so I am not sure, but perhaps we should just focus on
reducing the number of openssl commands rather than making easier the
integration of new files?  It could be possible to close the gap with
the addition of new files with some more documentation for future
hackers then?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Next Steps with Hash Indexes
Next
From: Peter Geoghegan
Date:
Subject: Re: Postgres picks suboptimal index after building of an extended statistics