Re: [PATCH] Pull general SASL framework out of SCRAM - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Pull general SASL framework out of SCRAM
Date
Msg-id YOzik3o+ps3XIlGZ@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Pull general SASL framework out of SCRAM  (Jacob Champion <pchampion@vmware.com>)
List pgsql-hackers
On Tue, Jul 13, 2021 at 12:01:46AM +0000, Jacob Champion wrote:
> Ah, right. I think the (!done && !success) case is probably indicative
> of an API smell, but that's probably something to clean up in a future
> pass.

Yeah, agreed.  I feel that it would should be cleaner to replace those
two booleans with a status enum or a bitmask.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Fix comments of heap_prune_chain()
Next
From: Masahiko Sawada
Date:
Subject: Re: Small documentation improvement for ALTER SUBSCRIPTION