Re: Different compression methods for FPI - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Different compression methods for FPI
Date
Msg-id YMrzT9Q8cwS0BtZj@paquier.xyz
Whole thread Raw
In response to Re: Different compression methods for FPI  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Thu, Jun 17, 2021 at 03:44:26PM +0900, Michael Paquier wrote:
> I have worked more on that today and finished with two patches:
> - 0001 is the mininal patch to add support for LZ4.  This is in a
> rather committable shape.  I noticed that we checked for an incorrect
> error code in the compression and decompression paths as LZ4 APIs can
> return a negative result.  There were also some extra bugs I spotted.
> Its size is satisfying for what it does, and there is MSVC support
> out-of-the-box:
>  12 files changed, 176 insertions(+), 48 deletions(-)
> - 0002 is the extra code need to add ZSTD and do the same.  This still
> requires support for MSVC and I have not checked the internals of ZSTD
> to see if we do the compress/decompress calls the right way.
>
> While on it, I am going to switch my buildfarm animal to use LZ4 for
> toast..  Just saying.

And I forgot to attach these.  (Thanks Andrey!)
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: pgbench logging broken by time logic changes
Next
From: Peter Eisentraut
Date:
Subject: Re: Python 3.10 breaks regression tests with traceback changes