Re: pg_regress.c also sensitive to various PG* environment variables - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_regress.c also sensitive to various PG* environment variables
Date
Msg-id YMP7XlGARe1v2MpZ@paquier.xyz
Whole thread Raw
In response to Re: pg_regress.c also sensitive to various PG* environment variables  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pg_regress.c also sensitive to various PG* environment variables
List pgsql-hackers
On Fri, Jun 11, 2021 at 10:08:20AM -0400, Alvaro Herrera wrote:
> I think if they're to be kept in sync, then the exceptions should be
> noted.  I mean, where PGCLIENTENCODING would otherwise be, I'd add
> /* PGCLIENTENCODING set above */
> /* See below for PGHOSTADDR */
> and so on (PGHOST and PGPORT probably don't need this because they're
> immediately below; not sure; but I would put them in alphabetical order
> in both lists for sure and then that wouldn't apply).  Otherwise I would
> think that it's an omission and would set to fix it.

Good idea, thanks.  I'll add comments for each one that cannot be
unsetted.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Table AM modifications to accept column projection lists
Next
From: Bruce Momjian
Date:
Subject: Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)