Re: Inaccurate error message when set fdw batch_size to 0 - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Inaccurate error message when set fdw batch_size to 0
Date
Msg-id YJoZqlo6x49TaJK6@paquier.xyz
Whole thread Raw
In response to Re: Inaccurate error message when set fdw batch_size to 0  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, May 10, 2021 at 10:09:40AM -0400, Tom Lane wrote:
> Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> writes:
>> if (value < 0) "requires a zero or positive integer value"
>> if (value <= 0) "requires a positive integer value"
>
> I was thinking of avoiding the passive voice and writing
>
>     "foo must be greater than zero"

Sounds like a good idea to me.

>> I'm not sure whether we should consider changing these messages:
>> remainder for hash partition must be a non-negative integer
>> parallel vacuum degree must be a non-negative integer
>> repeat count size must be a non-negative integer
>> number of workers must be a non-negative integer
>> %s requires a non-negative numeric value
>> distance in phrase operator should be non-negative and less than %d
>
> I think for consistency it'd be good to change 'em all.  I'm almost
> tempted to put this matter into our message style guide too.

+1.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: update/delete and execution-time partition pruning
Next
From: Laurenz Albe
Date:
Subject: Re: PG 14 release notes, first draft