Re: PATCH: Attempt to make dbsize a bit more consistent - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: PATCH: Attempt to make dbsize a bit more consistent
Date
Msg-id YG636TVWk3C+Sfm6@paquier.xyz
Whole thread Raw
In response to Re: PATCH: Attempt to make dbsize a bit more consistent  (gkokolatos@pm.me)
List pgsql-hackers
On Wed, Mar 17, 2021 at 02:35:28PM +0900, Michael Paquier wrote:
> So we would likely want a separate function.  Another possibility,
> which I find tempting, would be to push down the calculation logic
> relying on physical files down to the table AM themselves with a new
> dedicated callback (relation_size_physical?), as it seems to me that
> the most important thing users want to know with this set of functions
> is how much physical space is being consumed at one given point in
> time.  Attached is a small prototype I was just playing with.

Thinking more about that, I'd be rather in favor of having a new table
AM callback to let the AM measure the size of physical files, and make
the business of dbsize.c fall under that.  It is clear that this needs
more work, so I have marked it as returned with feedback.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit?
Next
From: Michael Paquier
Date:
Subject: Re: Support for NSS as a libpq TLS backend