Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses
Date
Msg-id YCsd7SwViL8mu6H/@paquier.xyz
Whole thread Raw
In response to Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses  (Ian Lawrence Barwick <barwick@gmail.com>)
Responses Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses
List pgsql-hackers
On Mon, Feb 15, 2021 at 03:57:04PM +0900, Ian Lawrence Barwick wrote:
> Indeed it does. Not the most exciting of use cases, though I imagine it
> might come in handy for anyone developing an extension, and the
> existing implementation is inconsistent (in place for ALTER INDEX,
> and partially for ALTER MATERIALIZED VIEW, but not the others).
> Patch suggestion attached.

Thanks.

-   else if (Matches("ALTER", "INDEX", MatchAny, "NO", "DEPENDS"))
-       COMPLETE_WITH("ON EXTENSION");
-   else if (Matches("ALTER", "INDEX", MatchAny, "DEPENDS"))
-       COMPLETE_WITH("ON EXTENSION");
The part, if removed, means that typing "alter index my_index no " is
not able to complete with "DEPENDS ON EXTENSION" anymore.  So it seems
to me that ALTER INDEX got that right, and that the other commands had
better do the same.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: PATCH: Batch/pipelining support for libpq
Next
From: Aleksei Ivanov
Date:
Subject: Fwd: Row description Metadata information