Re: Fix comment in SnapBuildFindSnapshot - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fix comment in SnapBuildFindSnapshot
Date
Msg-id Y4RnZAD9h+0hw1WM@paquier.xyz
Whole thread Raw
In response to Fix comment in SnapBuildFindSnapshot  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Fix comment in SnapBuildFindSnapshot
List pgsql-hackers
On Mon, Nov 28, 2022 at 11:13:23AM +0900, Masahiko Sawada wrote:
> We have the following comment in SnapBuildFindSnapshot():
>
>     * c) transition from FULL_SNAPSHOT to CONSISTENT.
>     *
>     * In FULL_SNAPSHOT state (see d) ), and this xl_running_xacts'
>
> It mentions "(state d) )", which seems like a typo of "(state d)", but
> there is no "state d" in the first place. Reading the discussion of
> the commit 955a684e040 that introduced this comment, this was a
> comment for an old version patch[1]. So I think we can remove this
> part.

Hm, yes, that seems right.  There are three "c) states" in these
paragraphs, they are incremental steps.  Will apply if there are no
objections.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Remove a unused argument from qual_is_pushdown_safe
Next
From: Ian Lawrence Barwick
Date:
Subject: Re: Understanding, testing and improving our Windows filesystem code