Re: Doc: fix track_io_timing description to mention pg_stat_io - Mailing list pgsql-hackers

From
Subject Re: Doc: fix track_io_timing description to mention pg_stat_io
Date
Msg-id TYWPR01MB10742991B5A3EA39B081DA0D4A4D02@TYWPR01MB10742.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Doc: fix track_io_timing description to mention pg_stat_io  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
List pgsql-hackers
> > On Thu, Jun 27, 2024 at 5:06 AM <Hajime.Matsunaga@nttdata.com> wrote:
> > >
> > > Hi,
> >
> > > pg_stat_io has I/O statistics that are collected when track_io_timing is
> > > enabled, but it is not mentioned in the description of track_io_timing.
> > > I think it's better to add a description of pg_stat_io for easy reference.
> > > What do you think?
> >
> > Seems quite reasonable to me given that track_wal_io_timing mentions
> > pg_stat_wal. I noticed that the sentence about track_io_timing in the
> > statistics collection configuration section [1] only mentions reads
> > and writes -- perhaps it should also mention extends and fsyncs?
>
> Both suggestions look good to me. If what you said will be
> implemented, maybe track_wal_io_timing too should mention fsyncs?

Thank you both for your positive comments.
I also think your suggestions seem good.


Regards,
--
Hajime Matsunaga
NTT DATA Group Corporation

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: ON ERROR in json_query and the like
Next
From: Junwang Zhao
Date:
Subject: stale comments about fastgetattr and heap_getattr