Dear Gyan,
Thanks for updating the patch!
While considering it further, I started to think the combination with -l and -v
is problematic.
For now, if -l and -v are set, info/debug-level messages are written only to the
file, whereas warning/error messages are written to both.
In the case of pg_upgrade, however, all additional messages are printed to both
the terminal and the file. They are similar programs, so we should follow the
spec. Also, there is another advantage that users can check the progress of the
command from INFO/DEBUG messages.
Since all comments were OK for you, I merged 0003 into 0002, and now all
messages would be printed on both stderr/log file. How do you think?
Can you also check other comments like posted on [1] and revise if needed?
[1]: https://www.postgresql.org/message-id/CABdArM54_cVUMfE2DGSnJfDBZO1hmaVb82Z4b+1t0fp+xqXaMQ@mail.gmail.com
Best regards,
Hayato Kuroda
FUJITSU LIMITED
