RE: Re-read subscription state after lock in AlterSubscription - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Re-read subscription state after lock in AlterSubscription
Date
Msg-id TYRPR01MB121568CC10A0920C7A5ADCCC2F5F52@TYRPR01MB12156.jpnprd01.prod.outlook.com
Whole thread
In response to Re: Re-read subscription state after lock in AlterSubscription  (Dilip Kumar <dilipbalaut@gmail.com>)
List pgsql-hackers
Dear Bertrand,

Good catch. Current code allows that old `sub` value is retained, so it sounds
reasonable fix even for me.

BTW, the issue that GetSubscription() is called before the LockSharedObject() looks
the existing issues even on REL_13_STABLE. So does it mean that there were no
cases that concurrent altering can be the unexpected state? At least,
"retain_dead_tuples" can avoid the issue because the launcher manages the
conflict slot.

Best regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Re-read subscription state after lock in AlterSubscription
Next
From: Amit Langote
Date:
Subject: Re: JSON_VALUE/JSON_TABLE DEFAULT expression ignores RETURNING typmod