RE: Allow logical replication to copy tables in binary format - Mailing list pgsql-hackers

Hi,


On Wednesday, March 15, 2023 2:34 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Tue, Mar 14, 2023 at 8:50 PM Takamichi Osumi (Fujitsu)
> <osumi.takamichi@fujitsu.com> wrote:
> >
> > On Tuesday, March 14, 2023 8:02 PM Melih Mutlu
> <m.melihmutlu@gmail.com> wrote:
> > (3) copy_table()
> >
> > +       /*
> > +        * If the publisher version is earlier than v14, it COPY command
> doesn't
> > +        * support the binary option.
> > +        */
> >
> > This sentence doesn't look correct grammatically. We can replace "it COPY
> command" with "subscription" for example. Kindly please fix it.
> >
> 
> How about something like: "The binary option for replication is supported since
> v14."?
Yes, this looks best to me. I agree with this suggestion.


Best Regards,
    Takamichi Osumi