RE: speed up a logical replica setup - Mailing list pgsql-hackers

Dear Alvaro,

> > 15.
> >
> > You said in case of failure, cleanups is not needed if the process exits soon [1].
> > But some functions call PQfinish() then exit(1) or pg_fatal(). Should we follow?
> 
> Hmm, but doesn't this mean that the server will log an ugly message that
> "client closed connection unexpectedly"?  I think it's nicer to close
> the connection before terminating the process (especially since the
> code for that is already written).

OK. So we should disconnect properly even if the process exits. I added the function call
again. Note that PQclear() was not added because it is only related with the application.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/