Postgres Pro
Downloads
Home   >   mailing lists

Re: PSQL error: total cell count of XXX exceeded - Mailing list pgsql-hackers

From Hongxu Ma
Subject Re: PSQL error: total cell count of XXX exceeded
Date
Msg-id TYBP286MB03515815935D9F6FA90C5921B4F1A@TYBP286MB0351.JPNP286.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: PSQL error: total cell count of XXX exceeded  (Jelte Fennema <postgres@jeltef.nl>)
Responses Re: PSQL error: total cell count of XXX exceeded
List pgsql-hackers
Tree view
Thank you for your advice, Jelte.
I have refactored my code, please see the attached patch. (and I put it into https://commitfest.postgresql.org/45/ for trace)

Thanks.

From: Jelte Fennema <postgres@jeltef.nl>
Sent: Monday, September 11, 2023 15:04
To: Hongxu Ma <interma@outlook.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: PSQL error: total cell count of XXX exceeded
 
On Mon, 11 Sept 2023 at 08:51, Hongxu Ma <interma@outlook.com> wrote:
>
> I created a patch to fix it.
> Really appreciate to anyone can help to review it.
> Thanks.

I think "product" as a variable name isn't very descriptive. Let's
call it total_cells (or something similar instead).

Other than that I think it's a good change. content->cellsadded is
also a long, So I agree that I don't think the limit of int cells was
intended here.
Attachment

pgsql-hackers by date:

Previous
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: [PoC] pg_upgrade: allow to upgrade publisher node
Next
From: Peter Smith
Date:
Subject: Re: Add 'worker_type' to pg_stat_subscription