Postgres Pro
Downloads
Home   >   mailing lists

RE: psql - factor out echo code - Mailing list pgsql-hackers

From
Subject RE: psql - factor out echo code
Date
Msg-id TYAPR01MB28962C85C5F2ECD7EF95BC7EC4319@TYAPR01MB2896.jpnprd01.prod.outlook.com
Whole thread Raw
In response to psql - factor out echo code  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses RE: psql - factor out echo code
List pgsql-hackers
Tree view 
>-----Original Message-----
>From: Fabien COELHO <coelho@cri.ensmp.fr>
>Sent: Sunday, May 30, 2021 6:10 PM
>To: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
>Subject: psql - factor out echo code
>
>
>While working on something in "psql/common.c" I noticed some triplicated code,
>including a long translatable string. This minor patch refactors this in one
>function.
>
>--
>Fabien.

Wouldn't it be better to comment it like any other function?

Best regards,
Shinya Kato

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Decoding speculative insert with toast leaks memory
Next
From: Dilip Kumar
Date:
Subject: Re: Decoding speculative insert with toast leaks memory