Dear Daniil, Chao,
I was the main author of 1462aad2. It is enough to remove outdated comments atop
the definition. In other words, your patch looks good to me.
If needed, we can also notify developers that the two-phase option should not be
altered while decoding WAL records. In logical replication, we ensure that the
subscription is disabled and there are no apply workers. However, I don't think
such comments can be atop the ReplicationSlotCreate(). Maybe around
ReplicationSlotAlter(), but it may be out of scope of the initial motivation.
By the way, the comment may have been broken since a8fd13. Even when the
subscription was defined with two_phase=on, the backend creates the slot with
two_phase = off. The configuration is changed after the tablesync is done.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
