Request a Demo
Home   >   mailing lists

RE: [Patch] Fix check_pub_rdt bypass when origin is set in same ALTER SUBSCRIPTION - Mailing list pgsql-hackers

From Zhijie Hou (Fujitsu)
Subject RE: [Patch] Fix check_pub_rdt bypass when origin is set in same ALTER SUBSCRIPTION
Date
Msg-id TY4PR01MB1771889056A7ECBE5CF8CBFB394122@TY4PR01MB17718.jpnprd01.prod.outlook.com
Whole thread
In response to Re: [Patch] Fix check_pub_rdt bypass when origin is set in same ALTER SUBSCRIPTION  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [Patch] Fix check_pub_rdt bypass when origin is set in same ALTER SUBSCRIPTION
List pgsql-hackers
Tree view 
On Saturday, May 30, 2026 6:19 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> 
> On Tue, May 26, 2026 at 3:50 PM SATYANARAYANA NARLAPURAM
> <satyanarlapuram@gmail.com> wrote:
> >
> > HI hackers,
> >
> > When ALTER SUBSCRIPTION SET (retain_dead_tuples = true, origin =
> > 'none') is used, the publisher version/recovery check was bypassed
> > because the origin handling unconditionally overwrote check_pub_rdt to
> false.
> >
> > Fix by using |= instead of = so that the flag set by
> > retain_dead_tuples cannot be cleared by a subsequent origin assignment in
> the same command.

Thanks for reporting ! I agree this needs to be fixed.

> >
> 
> Thanks for catching this. Your fix LGTM. I won't be able to commit today as I
> have to travel. In the meantime, let's see if Hou-San or others have any
> comments.

The fix looks good to me as well.

Best Regards,
Hou zj

pgsql-hackers by date:

Previous
From: Mats Kindahl
Date:
Subject: Re: pg_rewind does not rewind diverging timelines
Next
From: Amit Kapila
Date:
Subject: Re: DOCS - missing SGML markup in some ALTER PUBLICATION examples