Request a Demo
Home   >   mailing lists

Remove stale XXX comment in logical launcher - Mailing list pgsql-hackers

From Zhijie Hou (Fujitsu)
Subject Remove stale XXX comment in logical launcher
Date
Msg-id TY4PR01MB177186C8AB596F30DF704ECDC94B62@TY4PR01MB17718.jpnprd01.prod.outlook.com
Whole thread
Responses Re: Propagate stadistinct through GROUP BY/DISTINCT in subqueries and CTEs
List pgsql-hackers
Tree view 
Hi,

I noticed one comment in the launcher that can be removed:

             if (!retain_dead_tuples)
                /* XXX unclear why we don't request logical decoding disable */
                 ReplicationSlotDropAcquired(false);

Since the conflict detection slot is a physical one, there is no logical
decoding state to disable when dropping it. The condition it depends on is also
self-evident from the surrounding code and the block comment above, which
already explains why the slot is dropped. So here is a patch to remove the XXX
comment.

Best Regards,
Zhijie Hou
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: WAIT FOR command should do some query jumbling
Next
From: Alexander Nestorov
Date:
Subject: Re: gist_trgm_ops '=' operator: planner picks it over btree, ~300x slower