Request a Demo
Home   >   mailing lists

RE: Crashes on a partition whose concurrent detach never finished - Mailing list pgsql-hackers

From Zhijie Hou (Fujitsu)
Subject RE: Crashes on a partition whose concurrent detach never finished
Date
Msg-id TY4PR01MB177181B0B5A70FB78038B76C394BE2@TY4PR01MB17718.jpnprd01.prod.outlook.com
Whole thread
In response to Re: Crashes on a partition whose concurrent detach never finished  (Nisha Moond <nisha.moond412@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

On Friday, September 11, 2026 2:01 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
> 
> Thanks for sharing the patch. It looks good to me. I’ve updated the attached
> patch accordingly.

The fix looks mostly good to me. The only nit is that we could avoid introducing
a new Boolean flag by writing it like this:

RelationBuildPublicationDesc()
..
    if (relation->rd_rel->relispartition)
        ancestors = get_partition_ancestors(relid);

    if (ancestors)
    {
        Oid         last_ancestor_relid;

        last_ancestor_relid = llast_oid(ancestors);
...

Best Regards,
Zhijie Hou
Attachment

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Review items for EXCEPT TABLE publication
Next
From: Rahila Syed
Date:
Subject: Re: Fix unsafe coding in ResourceOwnerReleaseAll()