RE: POC: enable logical decoding when wal_level = 'replica' without a server restart - Mailing list pgsql-hackers

From Zhijie Hou (Fujitsu)
Subject RE: POC: enable logical decoding when wal_level = 'replica' without a server restart
Date
Msg-id TY4PR01MB16907680E27BAB146C8EB1A4294B2A@TY4PR01MB16907.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: POC: enable logical decoding when wal_level = 'replica' without a server restart  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: POC: enable logical decoding when wal_level = 'replica' without a server restart
List pgsql-hackers
Hi,

I noticed a BF failure [1] related to this commit.

Commit 67c209 removes the WARNING for insufficient wal_level from the output,
but the WARNING may still appear on BF animals that default to
wal_level=minimal.

To avoid tests that produce varying messages based on wal_level, we could modify
the test to use ALTER PUBLICATION for verifying the same NOTICE. Attached is a
small patch addressing this issue.

We could also simply remove these tests but that seems to reduce the test
coverage a bit.

---- publication.out diff ----
SET client_min_messages = 'NOTICE';
CREATE PUBLICATION regress_pub_for_allsequences_alltables_withclause FOR ALL SEQUENCES, ALL TABLES WITH (publish =
'insert');
NOTICE: publication parameters are not applicable to sequence synchronization and will be ignored for sequences
+WARNING: logical decoding must be enabled to publish logical changes
+HINT: Before creating subscriptions, ensure that "wal_level" is set to "replica" or higher.
CREATE PUBLICATION regress_pub_for_allsequences_withclause FOR ALL SEQUENCES WITH (publish_generated_columns =
'stored');
NOTICE: publication parameters are not applicable to sequence synchronization and will be ignored for sequences
+WARNING: logical decoding must be enabled to publish logical changes
+HINT: Before creating subscriptions, ensure that "wal_level" is set to "replica" or higher.

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=thorntail&dt=2025-12-24%2006%3A31%3A02

Best Regards,
Hou zj

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Orphaned records in pg_replication_origin_status after subscription drop
Next
From: "Aya Iwata (Fujitsu)"
Date:
Subject: RE: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE