RE: Logical Replication of sequences - Mailing list pgsql-hackers

On Friday, October 17, 2025 4:50 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> 
> On Thu, Oct 16, 2025 at 4:53 PM Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>
> wrote:
> >
> > Thanks! Here is the remaining patches, which addressed all pending
> comments.
> >
> 
> Few comments on 0001/0003:

Thanks for the comments.

> ========================
> 1.
> @@ -480,7 +480,9 @@ RemoveSubscriptionRel(Oid subid, Oid relid)
>   * leave tablesync slots or origins in the system when the
>   * corresponding table is dropped.
>   */
> - if (!OidIsValid(subid) && subrel->srsubstate != SUBREL_STATE_READY)
> + if (!OidIsValid(subid) &&
> + get_rel_relkind(subrel->srrelid) != RELKIND_SEQUENCE &&
> + subrel->srsubstate != SUBREL_STATE_READY)
>   {
> 
> Here, why don't we allow sequence rel to be removed? Please add some
> comments.

I think the intention is to allow removing sequence because we do not
create slot/origin when syncing sequence. I added some comments
for the same.

Other comments have been addressed in latest version.

Here is the latest patch set which addressed Shveta[1], Amit[2], Chao[3][4],
Dilip[5], Sawada-San's[6] comments.

Some of the code refactoring comments in [4] will be considered in
next versions.

[1] https://www.postgresql.org/message-id/CAJpy0uC898ga%2BQo3X%3Dk_MaRUL7EnmXt%2BppDJo-nroQZifrk5Hw%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAA4eK1K6Aofz_f6afuL%2Br2M3GfHBEYQ6-5JO93ph9xZAmYugSA%40mail.gmail.com
[3] https://www.postgresql.org/message-id/B0F583F9-6D4D-4C0F-9F35-64D5AB2F1643%40gmail.com
[4] https://www.postgresql.org/message-id/598FC353-8E9A-4857-A125-740BE24DCBEB%40gmail.com
[5] https://www.postgresql.org/message-id/CAFiTN-sC4yE_u7fa%2BUQS38JvhxN_VYSWTq2O_2bTRxxq%3DeW8FQ%40mail.gmail.com
[6] https://www.postgresql.org/message-id/CAD21AoBYP1a4%2B%2BALRPG%3DSmCoyGeGCcqhFxWSXYhy1cvmN0i3CA%40mail.gmail.com

Best Regards,
Hou zj