Request a Demo
Home   >   mailing lists

RE: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion? - Mailing list pgsql-hackers

From Zhijie Hou (Fujitsu)
Subject RE: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?
Date
Msg-id TY4PR01MB16907318494FF276465E97DF79453A@TY4PR01MB16907.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?  (Nisha Moond <nisha.moond412@gmail.com>)
Responses Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?
List pgsql-hackers
Tree view 
On Tuesday, March 31, 2026 2:02 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
> 
> 
> Please find the updated patch (v6) attached.

Thanks for updating the patch. One minor comment:

I think we could avoid interrupting and reporting an ERROR when
IsSyncingReplicationSlots() returns false to avoid reporting ERROR unnecessarily
when the slotsync has already finished.

Best Regards,
Hou zj

pgsql-hackers by date:

Previous
From: Christoph Berg
Date:
Subject: Re: pgsql: test_aio: Add basic tests for StartReadBuffers()
Next
From: shveta malik
Date:
Subject: Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?