RE: speed up a logical replica setup - Mailing list pgsql-hackers

Dear Fabrízio, Euler,

I think you set the primary_slot_name to the standby server, right?
While reading codes, I found below line in v11-0001.
```
    if (primary_slot_name != NULL)
    {
        conn = connect_database(dbinfo[0].pubconninfo);
        if (conn != NULL)
        {
            drop_replication_slot(conn, &dbinfo[0], temp_replslot);
        }
```

Now the temp_replslot is temporary one, so it would be removed automatically.
This function will cause the error: replication slot "pg_createsubscriber_%u_startpoint" does not exist.
Also, the physical slot is still remained on the primary. 
In short, "temp_replslot" should be "primary_slot_name".

PSA a script file for reproducing.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/