Re: Transaction timeout - Mailing list pgsql-hackers

From Japin Li
Subject Re: Transaction timeout
Date
Msg-id SY8PR01MB9288335A3B81E8D6E121980FB68AA@SY8PR01MB9288.ausprd01.prod.outlook.com
Whole thread Raw
In response to Re: Transaction timeout  ("Andrey M. Borodin" <x4mmm@yandex-team.ru>)
Responses Re: Transaction timeout
List pgsql-hackers
On Fri, 08 Dec 2023 at 18:08, Andrey M. Borodin <x4mmm@yandex-team.ru> wrote:
>> On 8 Dec 2023, at 12:59, Japin Li <japinli@hotmail.com> wrote:
>>
>>
>> On Thu, 07 Dec 2023 at 20:40, Andrey M. Borodin <x4mmm@yandex-team.ru> wrote:
>>>> On 7 Dec 2023, at 06:25, Japin Li <japinli@hotmail.com> wrote:
>>>>
>>>> If idle_in_transaction_timeout is bigger than transaction_timeout,
>>>> the idle-in-transaction timeout don't needed, right?
>>> Yes, I think so.
>>>
>>
>> Should we disable the idle_in_transaction_timeout in this case? Of cursor, I'm
>> not strongly insist on this.
> Good idea!
>
>> I think you forget disable transaction_timeout in AutoVacWorkerMain().
>> If not, can you elaborate on why you don't disable it?
>
> Seems like code in autovacuum.c was copied, but patch was not updated. I’ve fixed this oversight.
>

Thanks for updating the patch. LGTM.

--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.



pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: [HACKERS] make async slave to wait for lsn to be replayed
Next
From: Amit Langote
Date:
Subject: Re: remaining sql/json patches