Request a Demo
Home   >   mailing lists

Re: Convert NOT IN sublinks to anti-joins when safe - Mailing list pgsql-hackers

From Japin Li
Subject Re: Convert NOT IN sublinks to anti-joins when safe
Date
Msg-id SY7PR01MB10921F205A15712E60C7CA04FB679A@SY7PR01MB10921.ausprd01.prod.outlook.com
Whole thread Raw
In response to Convert NOT IN sublinks to anti-joins when safe  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Convert NOT IN sublinks to anti-joins when safe
List pgsql-hackers
Tree view 
On Sun, 08 Mar 2026 at 17:16, Richard Guo <guofenglinux@gmail.com> wrote:
> On Thu, Mar 5, 2026 at 10:57 AM Japin Li <japinli@hotmail.com> wrote:
>> Just a quick note: I think `foreach_ptr` is more appropriate here than `foreach`.
>
> Agreed.
>
> For homogeneous lists, it is better to use foreach_node so we get the
> additional type-safety assertions in dev builds.  For heterogeneous
> lists, we should use foreach_ptr.
>
> Attached is an updated version of the patch that replaces foreach with
> foreach_ptr or foreach_node accordingly.  Nothing else has changed.
>
> I plan to do one more round of self-review on this.  Unless there are
> any further thoughts or concerns, I'm hoping to commit this in a week
> or two.  Please let me know if anyone spots anything else I might have
> missed.
>

Thanks for updating the patch. LGTM.

--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [BUG + PATCH] DSA pagemap out-of-bounds in make_new_segment odd-sized path
Next
From: Boris Mironov
Date:
Subject: Re: Idea to enhance pgbench by more modes to generate data (multi-TXNs, UNNEST, COPY BINARY)