Use SMgrRelation instead of SMgrRelationData * in pgaio_io_set_target_smgr() - Mailing list pgsql-hackers

From Japin Li
Subject Use SMgrRelation instead of SMgrRelationData * in pgaio_io_set_target_smgr()
Date
Msg-id SY7PR01MB10921D0F6F3C2682570D6C31BB645A@SY7PR01MB10921.ausprd01.prod.outlook.com
Whole thread Raw
Responses Re: Use SMgrRelation instead of SMgrRelationData * in pgaio_io_set_target_smgr()
List pgsql-hackers
Hi, hackers

While reading smgr.h, I noticed an inconsistent type usage in
pgaio_io_set_target_smgr(). Currently the function is declared as:

    extern void pgaio_io_set_target_smgr(PgAioHandle *ioh,
                                         SMgrRelationData *smgr,
                                         ForkNumber forknum,
                                         BlockNumber blocknum,
                                         int nblocks,

However, SMgrRelation is defined as "typedef SMgrRelationData * SMgrRelation;",
and all other functions in the smgr subsystem use SMgrRelation as the parameter
type.

To keep the code consistent with the rest of the smgr API, this patch changes
the parameter from SMgrRelationData * to SMgrRelation in both the definition
and declaration.

This is purely a style/consistency cleanup with no functional change.

Thoughts? Is this change acceptable?

-- 
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.


Attachment

pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: [PATCH] Support automatic sequence replication