Use TEXT_DUMP_HEADER macro instead of hard-coded string in pg_backup_archiver.c - Mailing list pgsql-hackers

From Japin Li
Subject Use TEXT_DUMP_HEADER macro instead of hard-coded string in pg_backup_archiver.c
Date
Msg-id SY7PR01MB109213729ED3B2250E080D8A6B6132@SY7PR01MB10921.ausprd01.prod.outlook.com
Whole thread
Responses Re: Use TEXT_DUMP_HEADER macro instead of hard-coded string in pg_backup_archiver.c
List pgsql-hackers
Hi,

I noticed that in pg_backup_archiver.c, RestoreArchive() writes the dump header
using a hard-coded string:

       ahprintf(AH, "--\n-- PostgreSQL database dump\n--\n\n");

However, the macro TEXT_DUMP_HEADER (defined in the same file) already contains
exactly the same content.  To keep the code consistent and maintainable, this
patch replaces the hard-coded string with the macro.

A hard-coded version of TEXT_DUMPALL_HEADER exists in pg_dumpall.c, but since
it spans multiple files, it is left untouched.

-- 
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.


Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Fix regression in vacuumdb --analyze-in-stages for partitioned tables
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: PSA: Planning to grease protocol connections during 19beta