回复: are the 2 if-statements in join_is_legal() removable? - Mailing list pgsql-general

Hi Tom:
Thanks for your reply! I add  logs like this:

            if (bms_is_subset(sjinfo->min_lefthand, rel1->relids) &&

                  bms_is_subset(sjinfo->min_righthand, rel2->relids))

            {

                  if (match_sjinfo) {

                        return false;     /* invalid join path */

                  }

                  match_sjinfo = sjinfo;

                  reversed = false;

            }

            else if (bms_is_subset(sjinfo->min_lefthand, rel2->relids) &&

                         bms_is_subset(sjinfo->min_righthand, rel1->relids))

            {

                  if (match_sjinfo) {

                        return false;     /* invalid join path */

                  }

                  match_sjinfo = sjinfo;

                  reversed = true;

            }

            else if (sjinfo->jointype == JOIN_SEMI &&

                         bms_equal(sjinfo->syn_righthand, rel2->relids) &&

                         create_unique_path(root, rel2, rel2->cheapest_total_path,

                                                      sjinfo) != NULL)

            {

                  if (match_sjinfo) {

                        return false;     /* invalid join path */

                  }

                  match_sjinfo = sjinfo;

                  reversed = false;

                  unique_ified = true;

            }

            else if (sjinfo->jointype == JOIN_SEMI &&

                         bms_equal(sjinfo->syn_righthand, rel1->relids) &&

                         create_unique_path(root, rel1, rel1->cheapest_total_path,

                                                      sjinfo) != NULL)

            {

                  /* Reversed semijoin case */

                  if (match_sjinfo) {

                        return false;     /* invalid join path */

                  }

                  match_sjinfo = sjinfo;

                  reversed = true;

                  unique_ified = true;

            }

Then I run the core regression tests with "make installcheck-parallel

" for v18beta1 as the document dictates. When the regression test is done, only the last 2 log entries are found in logfile, the first 2 entries are not printed at all. I run core regression also with v14.15 and v17.2, the results are the same. What test suite do I need to run to cover the first 2 branches, or could you please show me a example query that can cover them? Thank you very much.