Hi Peter/Heikki/Tristan
Please find the attached changes for the below comments. Along with comments from Tristan.
Please let me know if these meson specific changes are fine.
0001-Support-for-AIX-meson-updates.pg19.patch - has the changes for the below comments only.
0001-Support-for-AIX-all-meson.pg19.patch - has all the meson specific changes.
>> 1) In meson.build:
>> + cppflags += '-D_GNU_SOURCE’
>> I don't think this symbol is applicable to AIX.
AIX provides certain functions similar to Linux, but with different names and
signatures. To align them with Linux behaviour, the GNU_SOURCE macro is defined,
which enables AIX functions to behave like their Linux counterparts.
You are right, this is not needed for AIX. I have removed and everything got build.
>> 2) In meson.build:
>> + # Native memset() is faster, tested on:
>> + memset_loop_limit = 0
>> The comment sentence appears to be truncated.
For now, removed this, I’ll provide statistics in a different thread as Heikki suggested.
>> 3) In meson.build:
>> +#if cc.alignment('int64_t', args: test_c_args, prefix: ‘#include
>> <stdint.h>') > alignof_double
>>+# error('alignment of int64_t is greater than the alignment of double’)
>> +#endif
>> This commented out code cannot be left like this. Either remove it or
>> adjust it as required.
I have updated the similar logic as in regular GNU configure file.
>> 4) In meson.build:
>> /* This must match the corresponding code in c.h: */
>> - #if defined(__GNUC__)
>> + #if defined(__GNUC__) || defined(__IBMC__)
>> You code does not observe what the comment says.
You are right, I have removed this as this is relevant only if we are compiling with XLC. Right now, its compiled with gcc
>> 5) The changes in src/include/port/aix.h are nonsense. This was
>> previously pointed out and you said you would address this.
The changes are irrelevant now, removed them. As all these additional definitions are covered by the postgres defined header file (src/include/utils/float.h). We can use “_H_FLOAT” to skip the system header "float.h”.
I’d like to finalize all Meson-specific changes first. Meanwhile, I’m also working on the other comments.
Kindly let me know your thoughts and feedback on the changes.
Thanks,
Sriram.
