Re: patch implementing the multi-argument aggregates (SOC - Mailing list pgsql-patches

From Sergey E. Koposov
Subject Re: patch implementing the multi-argument aggregates (SOC
Date
Msg-id Pine.LNX.4.64.0607251322080.19158@lnfm1.sai.msu.ru
Whole thread Raw
In response to Re: patch implementing the multi-argument aggregates (SOC project)  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: patch implementing the multi-argument aggregates (SOC project)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Some small clean-up of the patch...

+ implementing the Tom's idea of minimizing the copying of the data inside
advance_transition_function by using the temporary FunctionCallInfoData
(now the computed arguments of the aggregates are putted directly into
proper fcinfo.args fields, ready for the transition function call).

On Mon, 24 Jul 2006, Tom Lane wrote:
> Instead of copying data inside advance_transition_function, it might
> be better for the caller to store the values into the right fields
> of a temporary FunctionCallInfoData struct, and just pass that to
> advance_transition_function.


Regards,
     Sergey

*******************************************************************
Sergey E. Koposov
Max Planck Institute for Astronomy/Sternberg Astronomical Institute
Tel: +49-6221-528-349
Web: http://lnfm1.sai.msu.ru/~math
E-mail: math@sai.msu.ru

Attachment

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Patch for units in postgresql.conf
Next
From: "William ZHANG"
Date:
Subject: Patch for VS.Net 2005's strxfrm() bug