Re: pgsql: Recognize ERROR_SHARING_VIOLATION (translate to EACCES), - Mailing list pgsql-committers

From Qingqing Zhou
Subject Re: pgsql: Recognize ERROR_SHARING_VIOLATION (translate to EACCES),
Date
Msg-id Pine.LNX.4.58.0510071906160.19651@eon.cs
Whole thread Raw
In response to pgsql: Recognize ERROR_SHARING_VIOLATION (translate to EACCES), increase  (tgl@svr1.postgresql.org (Tom Lane))
Responses Re: pgsql: Recognize ERROR_SHARING_VIOLATION (translate to EACCES),  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
"Tom Lane" <tgl@svr1.postgresql.org> wrote
> Recognize ERROR_SHARING_VIOLATION (translate to EACCES), increase log
> level for unrecognized win32 error codes to LOG, and make messages
> conform to style guide.

This patch does not really work. This is because when mdread()/mdwrite()
fails, it does *not* call our own _dosmaperr() routine. Instead, it calls
the Win32 CRT's _dosmapperr() to do the translation (which fails to
translate ERROR_SHARING_VIOLATION either). If we want our _dosmaperr() to
play role in, we have to call it explicitely in mdread()/mdwrite() or
lower levels like FileRead()/FileWrite().

I would suggest don't revert this patch. When we get the feedback from
Jean-Pierre Pelletier, we can make the patch complete.

Regards,
Qingqing




pgsql-committers by date:

Previous
From: aglio@pgfoundry.org (User Aglio)
Date:
Subject: press - pr: Extended the "licensing" paragraph to be more pointed.
Next
From: "Qingqing Zhou"
Date:
Subject: Re: pgsql: Recognize ERROR_SHARING_VIOLATION (translate to EACCES), increase