Re: Unit testing - Mailing list pgsql-hackers

From Gavin Sherry
Subject Re: Unit testing
Date
Msg-id Pine.LNX.4.58.0410121054250.25608@linuxworld.com.au
Whole thread Raw
In response to Re: Unit testing  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, 11 Oct 2004, Tom Lane wrote:

> Neil Conway <neilc@samurai.com> writes:
> > On Tue, 2004-10-12 at 00:43, Tom Lane wrote:
> >> Most likely (and I for one will for sure resist any attempt to force
> >> global uniqueness on static names).
>
> > You're right that the issue can be avoided easily enough, but what need
> > is there _not_ to have globally unique function names?
>
> To me that's pretty much in the you've-got-to-be-kidding domain.  The
> reason static functions and local name scoping were invented was exactly
> to avoid having to ensure every single name is unique across a whole
> project.  The overhead of avoiding duplicates swamps any possible
> benefit.

I agree. I think we can use #include foo.c and in any situation where we
*may* run into duplicate statics, a few lines of sed magic should be
enough. Thus, we would have no impact on the existing code.

Gavin


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Unit testing
Next
From: "Marc G. Fournier"
Date:
Subject: Re: CVS fixed ...