Re: Minor BEFORE DELETE trigger fix - Mailing list pgsql-patches

From Gavin Sherry
Subject Re: Minor BEFORE DELETE trigger fix
Date
Msg-id Pine.LNX.4.58.0408131403100.14105@linuxworld.com.au
Whole thread Raw
In response to Re: Minor BEFORE DELETE trigger fix  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
On Thu, 12 Aug 2004, Bruce Momjian wrote:

>
> Did this get resolved?
>
> ---------------------------------------------------------------------------
>
> Gavin Sherry wrote:
> > Attached is a minor patch to make BEFORE DELETE triggers honour tgenabled
> > properly.
> >
> > I know that we cannot, currently, use this feature through a DDL command
> > but just in case someone is updating the catalogs to do it and since it is
> > necessary in order to implement disabling of triggers, I thought I'd send
> > it in.
> >
> > Gavin

After taking a proper look, I agree with Tom that my patch was not the
proper solution to the problem. What we really need for the BEFORE
ROW triggers is the ability to say that there were no triggers executeed.
At the moment, if no triggers are executed (ie, they're all disabled),
then the executor thinks that a trigger returned NULL.

I'll try to find some time to fix this soon. As I noted, though, its not
critical because there's no DDL to disable a trigger.

Gavin

pgsql-patches by date:

Previous
From: Oliver Jowett
Date:
Subject: Re: Add GUC_REPORT to server_encoding, integer_datetimes
Next
From: Gavin Sherry
Date:
Subject: ALTER INDEX