Re: pg_largeobject and tablespaces - Mailing list pgsql-hackers

From Gavin Sherry
Subject Re: pg_largeobject and tablespaces
Date
Msg-id Pine.LNX.4.58.0406242033080.29539@linuxworld.com.au
Whole thread Raw
In response to Re: pg_largeobject and tablespaces  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, 23 Jun 2004, Tom Lane wrote:

> Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
> > With our new tablespace set up, is it ever possible for someone to move
> > pg_largeobject to another tablespace?
>
> Assuming that ALTER TABLE SET TABLESPACE gets in, my preferred answer is
> to apply that operation to pg_largeobject.
>
> We do need to think a bit about what the safety constraints on ALTER
> TABLE SET TABLESPACE should be.  To allow the above, we cannot
> completely forbid moving system catalogs.  However, it will not work
> to allow moving *every* system catalog ... for instance, if you were to
> move pg_class itself, things would be more than slightly broken, because
> the backend could not find pg_class to learn where the system catalogs
> are.

Good point. I'm still yet to finish this patch as it was a little more
complex than I anticipated. At first, I added new entries to the queue for
ALTER TABLE in ATPrepCmd(). This didn't work because the toast and toast
index calls couldn't see themselves because they were droped when we
switch relfilenodes.

Then I realised that bad things happened if you changed the toast OIDs.
So, I'm going to work out a more elegant solution.

>
> It might be that we only need to forbid moving the "nailed" system
> relations, but I haven't thought it through yet.

Hmm.. that sounds okay.

Gavin


pgsql-hackers by date:

Previous
From: "Jeroen T. Vermeulen"
Date:
Subject: Re: PREPARE and transactions
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] Configuration patch