Re: UW 713UP3 patch - Mailing list pgsql-patches

From Peter Eisentraut
Subject Re: UW 713UP3 patch
Date
Msg-id Pine.LNX.4.44.0311022222210.1528-100000@peter.localdomain
Whole thread Raw
In response to UW 713UP3 patch  (Larry Rosenman <ler@lerctr.org>)
Responses Re: UW 713UP3 patch
List pgsql-patches
Larry Rosenman writes:

> Since peter objects to my methods, what is an ACCEPTABLE way to detect
> the 7.1.3UP3 compiler?

One POSSIBLE way to do this properly is to write a test that

1) Uses $CC, $CFLAGS, and related variables rather than hardcoding 'cc -O'.

2) Names any test files conftest.*, so configure cleans up automatically.

3) Doesn't execute any compiled programs.  See the __FAST_MATH__ test for
   an example.

However, I still think that we should not bother testing for this.
Considering that the condition first occurred a couple of months ago and
is already fixed, this isn't a big issue.  Think about what would happen
if we had to develop and maintain fixes for every buggy GCC compiler every
released.

--
Peter Eisentraut   peter_e@gmx.net


pgsql-patches by date:

Previous
From: Larry Rosenman
Date:
Subject: UW 713UP3 patch
Next
From: Larry Rosenman
Date:
Subject: Re: UW 713UP3 patch