Re: MinGW patch - Mailing list pgsql-patches

From Peter Eisentraut
Subject Re: MinGW patch
Date
Msg-id Pine.LNX.4.44.0309071806490.1172-100000@peter.localdomain
Whole thread Raw
In response to Re: MinGW patch  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses WIN32_CONSOLE usage
List pgsql-patches
Bruce Momjian writes:

> The problem is that mbvalidate() has this code:
>
>         if (GetVariableBool(pset.vars, "WIN32_CONSOLE"))
>             CharToOem(pwcs, pwcs);
>
> That's why I needed the #ifdef so it only tests from psql.  This code
> was just broken without that test, and because no one else has done
> Win32 compiles since it was added, no one saw it.

Interesting, considering that WIN32_CONSOLE isn't being set anywhere.

Anyway, that code needs to be removed/fixed, for the mentioned reasons.

--
Peter Eisentraut   peter_e@gmx.net


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Index creation takes for ever
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Index creation takes for ever