Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)
Date
Msg-id Pine.LNX.4.44.0308311200120.1119-100000@peter.localdomain
Whole thread Raw
In response to Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)  (Lee Kindness <lkindness@csl.co.uk>)
Responses Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)
Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)
Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)
List pgsql-hackers
Lee Kindness writes:

> You don't... and you simply shouldn't care. If there is a_r version
> available then we should use it - even if the plain version is "safe".

The problem with this is that the automatic determination (in configure)
whether there is a xxx_r()  version is, in general, fragile.  We cannot
rely on configure saying that xxx_r() doesn't exist, so the plain xxx()
should be good enough.  Else, we'd be shipping claimed-to-be-thread-safe
libraries that might trigger bugs that will be hard to track down.

I don't see any other solution than keeping a database of NEED_XXX_R for
each platform and then requiring these functions to show up before we
declare a library to be thread-safe.  So far we're only dealing with three
functions, to it should be doable.

-- 
Peter Eisentraut   peter_e@gmx.net



pgsql-hackers by date:

Previous
From: Lee Kindness
Date:
Subject: Re: Unixware Patch (Was: Re: Beta2 Tag'd and Bundled ...)
Next
From: ohp@pyrenet.fr
Date:
Subject: pg_dump bug?