Tom Lane writes:
> (This suggests that -lpgport ought to be stuck on the front of LIBS,
> not the back, in Makefile.global. What do you think?)
Correct.
> What I've done for the moment is to not test for hstrerror in configure,
> so that the non-HAVE_HSTRERROR path is always taken in getaddrinfo.c.
>
> One way we could go from here is to institutionalize that approach.
> I think that would require us to figure out how to do internationalization
> of strings that appear in this file (which remember can be compiled in
> multiple places). If there's a reasonably clean way to do that, I'm
> leaning to that approach. The other possibility is to decide to rely on
> hstrerror anyway, which will require fixing the link-order problem and
> testing to see if we need to provide our own prototype for it.
I'm not too concerned about that right now. Modern systems have
getaddrinfo() and semi-modern systems have hstrerror(), and the rest can
do with "error %d". (I suppose the make-libpq-thread-safe movement will
have its own opinion on that.)
Eventually, the system's message localization facilities will have to be
bypassed, so the server can send different languages to log and clients.
So strerror() and the like will have to be replaced anyway.
--
Peter Eisentraut peter_e@gmx.net
