Re: String changes - Mailing list pgsql-patches

From Dennis Björklund
Subject Re: String changes
Date
Msg-id Pine.LNX.4.44.0303081927110.27526-100000@zigo.dhs.org
Whole thread Raw
In response to Re: String changes  (Patrick Welche <prlw1@newn.cam.ac.uk>)
Responses Re: String changes  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: String changes  (Patrick Welche <prlw1@newn.cam.ac.uk>)
List pgsql-patches
On Sat, 8 Mar 2003, Patrick Welche wrote:

> > -                puts(gettext("Using pager is always."));
> > +                puts(gettext("Always use pager."));
> >              else
> >                  puts(gettext("Using pager is off."));
>
> Then how about "Never use pager." ?

This setting is still mostly boolean, it toggles between on and off if you
don't explicitly set it. I left it as is because most other settings are
still on/off.

I changed "Using pager is always." because it is not good english.

For me it's fine with "Using pager is off." but I wouldn't protest if it
was changed. Both are just as fine if you ask me.

> > -    fprintf(output, _("\n"));
> > +    fprintf(output, "\n");
>
> and what about all the other _( ) ? (Looks a bit like php to me..)

I don't know what you ask here. Do you have an example of a _( ) that is
not needed then it should be removed of course. The rest that I saw was
needed.

_() is used for translations. To mark "\n" for translation make no sense.

--
/Dennis


pgsql-patches by date:

Previous
From: Patrick Welche
Date:
Subject: Re: String changes
Next
From: Tom Lane
Date:
Subject: Re: String changes