Re: inline newNode() - Mailing list pgsql-patches

From Peter Eisentraut
Subject Re: inline newNode()
Date
Msg-id Pine.LNX.4.44.0210120047180.928-100000@localhost.localdomain
Whole thread Raw
In response to Re: inline newNode()  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: inline newNode()  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian writes:

> Peter Eisentraut wrote:
> > Bruce Momjian writes:
> >
> > > I assume the GEQO results he is seeing is only for a tests, and that the
> > > macro version of newNode will help in all cases.
> >
> > Well are we just assuming here or are we fixing actual problems based on
> > real analyses?
>
> What is your point?  He is testing GEQO, but I assume other places would
> see a speedup from inlining newNode.

That's exactly my point: You're assuming.

Of course everything would be faster if we inline it, but IMHO that's the
compiler's job.

--
Peter Eisentraut   peter_e@gmx.net


pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: INSTALL updates
Next
From: Peter Eisentraut
Date:
Subject: Re: INSTALL updates