Re: [PATCHES] utils C files - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCHES] utils C files
Date
Msg-id Pine.LNX.4.44.0207182006150.9047-100000@localhost.localdomain
Whole thread Raw
Responses Re: [PATCHES] utils C files
List pgsql-hackers
Bruce Momjian writes:

> Oh, so you are saying let most uses of src/port use the *.o files that
> are in the directory, and it isn't needed to have other directories use
> the link trick.  Just let me know what people want.

What I want is this:

In configure.in, call

AC_REPLACE_FUNCS([inet_aton ...])  # the whole list

If you need more sophisticated checks on top of "function exists", you
keep the existing tests, but instead of, say,

SNPRINTF=snprintf.c
AC_SUBST(SNPRINTF)

you'd call

AC_LIBOBJ(snprintf)

In Makefile.global.in:

LIBOBJS = @LIBOBJS@

In utils/port/Makefile:

libpgport.a: $(LIBOBJS)ar crs $@ $^

In Makefile.global.in:

Add -L$(top_builddir)/src/port to LDFLAGS (near the start), -lpgport to
LIBS (near the end).

Then you need to make sure that the src/port directory is build before
being referred to.

In the libpq makefile, you can write the rules like:

ifneq(,$(filter snprintf.o, $(LIBOBJS)))
# do what it's doing now in case of 'ifdef SNPRINF'
endif


Caveat implementor.

-- 
Peter Eisentraut   peter_e@gmx.net



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: compiler warnings from cvs tip
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] utils C files