Re: [ODBC] MD5 support for ODBC - Mailing list pgsql-patches

From Peter Eisentraut
Subject Re: [ODBC] MD5 support for ODBC
Date
Msg-id Pine.LNX.4.30.0111121934470.640-100000@peter.localdomain
Whole thread Raw
In response to Re: [ODBC] MD5 support for ODBC  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [ODBC] MD5 support for ODBC
List pgsql-patches
Bruce Momjian writes:

> ! all: check_md5 SUBSYS.o
> !
> ! check_md5:
> !       @cmp -s md5.c ../../interfaces/odbc/md5.c || \
> !       (echo "src/interfaces/odbc/md5.c doesn't match src/backend/libpq/md5.c" && \
> !        exit 1)

Nope, this doesn't work.  The source directory is not necessarily the
current directory.

I don't think it's particularly useful to put checks of static source
files in the build path.  There are quite a number of places that need to
be synchronized manually and there is no check anywhere.  It would
probably have been better to have one master copy of the file and symlink
it to whereever else it is needed.  (See libpq Makefile for several
examples.)

--
Peter Eisentraut   peter_e@gmx.net


pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: ALTER TABLE RENAME fix
Next
From: Peter Eisentraut
Date:
Subject: Re: Patch for Makefile race against current cvs