Re: More fixes for missing double quotes in the shell - Mailing list pgsql-patches

From Peter Eisentraut
Subject Re: More fixes for missing double quotes in the shell
Date
Msg-id Pine.LNX.4.30.0109300025190.629-100000@peter.localdomain
Whole thread Raw
In response to Re: More fixes for missing double quotes in the shell scripts  (Justin <justin@postgresql.org>)
Responses Re: More fixes for missing double quotes in the shell  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Justin writes:

> I agree it's not strictly necessary, but I thought I'd add them in to
> follow the generic "good programming practise" of always quoting
> variables in shell script tests.

In my purely personal opinion it's better to be aware of the possible
values of a variable than to blindly quote everything.  Somewhere you're
going to run into nested quote situations which cannot be done portably,
at which point you have to start doing that anyway.

--
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Problem with setlocale (found in libecpg) [accessing a memory location after freeing it]
Next
From: Peter Eisentraut
Date:
Subject: Re: Trailing semicolons in psql patch