Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal - Mailing list pgsql-patches

From Peter Eisentraut
Subject Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal
Date
Msg-id Pine.LNX.4.30.0109041213480.828-100000@peter.localdomain
Whole thread Raw
In response to Re: Patch for pl/tcl Tcl_ExternalToUtf and  (Tatsuo Ishii <t-ishii@sra.co.jp>)
List pgsql-patches
Tatsuo Ishii writes:

> > Tatsuo Ishii <t-ishii@sra.co.jp> writes:
> > > But if the config switch was removed, Tcls prior 8.1 would not be
> > > supported at all, no?
> >
> > No, Peter wasn't proposing removing #if's from the code.  His thought
> > is that the #if's should be conditional only on Tcl version --- if you
> > have a Tcl version that does UTF, then you get the translation code.
>
> Oh, I see.

The important thing here is not "does UTF", but "requires UTF".  Without
this patch enabled in Tcl >=8.1 you would fly along at 7 bits, which is
rather unusable for almost anyone.  If there are really serious
performance problems I could see a switch to turn it off.  But we're
already hearing every week about people with character set problems with
the JDBC driver, so we shouldn't lay more traps like that while knowing
better.

--
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter


pgsql-patches by date:

Previous
From: Vsevolod Lobko
Date:
Subject: Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal
Next
From: Reinhard Max
Date:
Subject: Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal