Re: Python (PyGreSQL) make install patch - Mailing list pgsql-patches

From Peter Eisentraut
Subject Re: Python (PyGreSQL) make install patch
Date
Msg-id Pine.LNX.4.30.0105251721130.758-100000@peter.localdomain
Whole thread Raw
In response to Re: Python (PyGreSQL) make install patch  (Jason Tishler <Jason.Tishler@dothill.com>)
Responses Re: Python (PyGreSQL) make install patch
List pgsql-patches
Jason Tishler writes:

> > Rip out the python makefile and reimplement the build yourself.  ;-)
>
> Did you say rip?  See attached for a patch that converts from using the
> traditional Makefile.pre.in style of building Python extensions to the
> newer Distutils style.  This patch is *not* final -- its more of a proof
> of concept to see if such a patch would be accepted when finished.

I don't think this does anything in the way of fixing the outlined
problems.  Moreover, it won't work with Python <2.x.  What I meant with
"rip" was to get rid of all the makefile generating tools and write our
own makefile.

> My patch also has the follow issues/changes:
>
> 1. pg.py is installed in $(prefix)/lib/python2.1/site-packages instead of
>    $(prefix)/lib/python2.1.  I believe this to be more correct or at least
>    this what Distutils tries to do.

I think if you build locally from source you want site-packages and if you
make a binary distribution that is considered part of the OS core then you
don't.  Probably go for the former by default.

> 2. pgdb.py is also installed (as done by the original setup.py).

Oops.

> 3. The new setup.py doesn't handle Win32 yet (like the original one sort
>    of did).

Not sure whether we are expected to care.

--
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter


pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Python (PyGreSQL) make install patch
Next
From: Bruce Momjian
Date:
Subject: Re: Cygwin plpython patch