Lamar Owen writes:
> Uploaded. Please take a look.
>
> ftp://ftp.postgresql.org/pub/dev/test-rpms
>
> There _are_ changes. I will detail the changes for the RC4 RPMset.
Coupla issues:
I'm confused about the logging. You install a logrotate configuration
which talks about a file /var/log/postgresql, but the spec file creates a
directory /var/log/pgsql/. Meanwhile, the start script you provide sends
the log output to /dev/null.
stop() in the init script should use pg_ctl -m fast.
PGVERSION in the init script is still at beta6. Maybe you should track
this from the source or the spec file.
You're still shipping old jar files. You could build them from the source
package.
In 'make COPT="$CFLAGS" all', the COPT shouldn't be used. You should
export CFLAGS before running configure. (What about CXXFLAGS?)
Before long, 'cp /usr/lib/python1.5/config/Makefile.pre.in .' is going to
get out of date. There's already Python 1.6 and 2.0. Since you're
configuring --with-python, the work you do there isn't necessary anyway,
since 'make all' takes care of it.
'make -C doc' is a no-op. Also, the docs are installed automatically, the
stuff you do under '# man pages....' needs some work. You probably want
to run gzip on the files after installation.
--
Peter Eisentraut peter_e@gmx.net http://yi.org/peter-e/
